fix(native): missing pointerId in pointer events #3347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue related to
@react-three/drei
repository: #2067.Analysis and explanation
The problem exists in
handleTouchMoveDolly
method ofOrbitControls
class inthree-stdlib
.dollyDelta.y
value isNaN
, becausedollyStart.y
anddollyEnd.y
indollyEnd.y / dollyStart.y
are 0. It happens because ofgetSecondPointerPosition
function which usesevent.pointerId
to identify pointers in arrays. Becauseevent.pointerId
is missing the method always returns the same pointer position, giving zero in the next calculations.Please also look at
removePointer
andtrackPointer
methods above - they useevent.pointerId
as well.